Add 3.12 to action, but without cython support #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
reviewed
Jan 15, 2024
.github/workflows/tests.yml
Outdated
Comment on lines
126
to
127
| # Builds without Cython at runtime. This is a core feature; | ||
| # everything should be able to run this. |
There was a problem hiding this comment.
We should update the comment to mention why we have an extra non-Cython run for 3.12.
hodgestar
reviewed
Jan 15, 2024
qutip/__init__.py
Outdated
| warnings.warn( | ||
| "The new version of Cython, (>= 3.0.0) is not supported." | ||
| .format(_Cython.__version__) | ||
| ) | ||
| elif _version2int(_Cython.__version__.split()[0]) >= _version2int("3.12.0"): |
There was a problem hiding this comment.
I'm not sure I understand this elif condition. We appear to be comparing a Python version to a Cython version?
hodgestar
reviewed
Jan 15, 2024
qutip/tests/conftest.py
Outdated
| return | ||
| import qutip | ||
| if not qutip.settings.has_cython: | ||
| pytest.skip("Cython not available at runtime.") |
There was a problem hiding this comment.
I'm a bit uncomfortable relying on QuTiP's own detection magic to skip tests. If it ends up being wrong in some cases Cython tests will be silently skipped in CI.
Perhaps let's just check against the Python version and skip if it's Python 3.12?
hodgestar
approved these changes
Jan 15, 2024
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
hodgestar
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add python 3.12 to automated test and wheel build.
However python 3.12 removed the
impmodule used bypyximport.The fix on cython side may only be for cython 3.X, so we run without cython at runtime on 3.12.
Related to #2293