Add error message to MemoryError #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericgig
force-pushed
the
misc.memory_error_msg
branch
from
0e37d3e
to
9301d66
Compare
hodgestar
reviewed
Jan 24, 2024
There was a problem hiding this comment.
The code changes seem fine, but it looks like some tests are failing.
Could we also write some tests for these? It might be a little bit tricky in some cases, but hopefully we can at least cover the easier ones (e.g. directly creating big dense or big sparse data objects).
|
The failing test are related to #2301 not being merged in yet. I am not sure we want tests for this. |
|
Agreed that it is tricky to test. I mostly wanted the tests because the nice error messages might contain bugs. Happy to let this slide for now though. |
hodgestar
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we can't allocate enough memory for a matrix, there was no error message.
For sparse array, were the users expect the it not to take that much space, this can be confusing.
I added error message which tell the shape of the matrix and number of elements.
It won't help much, but may show that the matrix is not as sparse as expected.
Related issues or PRs
#2299