Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import array from numpy instead of scipy #2305

Merged
merged 3 commits into from Jan 24, 2024

Conversation

evmckinney9
Copy link

@evmckinney9 evmckinney9 commented Jan 23, 2024

Description
Remove use of scipy.array in parallel.py, which is incompatible with scipy==1.12
Fix #2300

@evmckinney9 evmckinney9 marked this pull request as ready for review January 24, 2024 00:01
@evmckinney9 evmckinney9 marked this pull request as draft January 24, 2024 00:02
@evmckinney9 evmckinney9 marked this pull request as ready for review January 24, 2024 00:05
Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

There are other issues with scipy 1.12 for v4 in steadystate.
Are you interested in fixing them here or do you prefer we merge this as is and fix the rest in another PR?

@evmckinney9
Copy link
Author

There are other issues with scipy 1.12 for v4 in steadystate.

At a glance, it is not clear to me where the issues are. I confirmed that each scipy function used by steadystate.py exists and is successfully imported.

@Ericgig
Copy link
Member

Ericgig commented Jan 24, 2024

The issue is not with import, but deprecation warnings.
For our tests, warnings are considered errors.
This is why the tests using scipy 1.12 are still failing.
We will fix this on our side.

Thank you again for your contribution.

@Ericgig Ericgig merged commit 1692198 into qutip:qutip-4.7.X Jan 24, 2024
11 of 13 checks passed
@evmckinney9 evmckinney9 deleted the evmckinney9-issue2300 branch January 24, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants