Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mcsolve's test_super_H test tolerance. #2344

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Mar 4, 2024

Description
test_super_H can randomly fail, as seen in https://github.com/qutip/qutip/actions/runs/8112849659/job/22174928821.

Trying it locally, it fail with a probability of ~1/500.
Which is very close to what is expected with the tolerance used in the test.
I loosen the test atol for an expected rate of failure of about ~1/100000.

@coveralls
Copy link

Coverage Status

coverage: 85.91%. remained the same
when pulling c096c79 on Ericgig:misc.flacky_mcsolve_test
into 900bf79 on qutip:master.

@Ericgig Ericgig merged commit 87bec58 into qutip:master Mar 4, 2024
11 of 12 checks passed
@Ericgig Ericgig deleted the misc.flacky_mcsolve_test branch March 4, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants