Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing svd_csr test #2361

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix failing svd_csr test #2361

merged 3 commits into from
Mar 26, 2024

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Mar 24, 2024

Description
The sparse svd test is causing segfault in a setup that I can't reproduce.
The function svd_csr was never used as it could not work as a svd_dense replacement: _data.svd(csr) would use svd_dense.

So I simply removed the function.

@Ericgig Ericgig changed the title Remove svd_csr Fix failing svd_csr test Mar 26, 2024
@coveralls
Copy link

coveralls commented Mar 26, 2024

Coverage Status

coverage: 86.032%. first build
when pulling 0d6b29b on Ericgig:bugs.sparse_svd
into 1037dc5 on qutip:master.

@Ericgig
Copy link
Member Author

Ericgig commented Mar 26, 2024

There is one particular setup where the sparse eigen solver segfault. This happen with pure scipy and is not related to qutip.
Looking into it, I saw that when we installed qutip, it updated scipy version. It downgraded scipy 1.12 to 1.11, thus we never tested for 1.12.
Also build isolation meant that the version of numpy, scipy and cython we set in our test matrix did not match the one at installation. This is not ideal for cython since the compilation version could have a major impact.

I set it to not use build isolation and used the matrix set version to compile qutip.
This had the side effect of not using the setup that caused the segfault and solving the failing test issue.

@Ericgig Ericgig requested a review from hodgestar March 26, 2024 01:10
.github/workflows/tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
@Ericgig Ericgig merged commit aef84ea into qutip:master Mar 26, 2024
10 of 11 checks passed
@Ericgig Ericgig deleted the bugs.sparse_svd branch March 26, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants