Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument type in doctring of projection() #2363

Merged
merged 3 commits into from Mar 26, 2024
Merged

Fix argument type in doctring of projection() #2363

merged 3 commits into from Mar 26, 2024

Conversation

omnster
Copy link
Contributor

@omnster omnster commented Mar 26, 2024

In projection(dim, m, n, ...), m,n are Fock state numbers, so must be integers. Also matches the docstring of basis() which is used by projection().

@omnster
Fix argument type in doctring of projection()
ee9be66 
In projection(dim, m, n, ...), m,n are Fock state numbers, so must be
integers.  Also matches docstring of basis()
@omnster
add towncrier
fe87a70
@omnster
amend towncrier
65cc3eb
@coveralls
Copy link

coveralls commented Mar 26, 2024 •
edited

Coverage Status

coverage: 86.032%. remained the same
when pulling 65cc3eb on omnster:omnster/proj
into aef84ea on qutip:master.

Ericgig
Ericgig approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ericgig Ericgig merged commit 57ab0af into qutip:master Mar 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericgig Ericgig Ericgig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omnster @coveralls @Ericgig