Fix raise on too large min_step in krylov #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
approved these changes
Apr 23, 2024
Ericgig
added a commit
to Ericgig/qutip
that referenced
this pull request
May 16, 2024
Fix raise on too large min_step in krylov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error for too large minimum step was not raised.
The error therefore came later in scipy code and was hard to understand.
Found from https://groups.google.com/g/qutip/c/NUcKnAwpx30/m/7IKDqbNOAgA
Fix the error and add a test for it.
Also added some sanity check on
min_stepandmax_step, which could create infinite loop ifmin_step = 0ormin_step > max_step.