New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic args #990
dynamic args #990
Conversation
@Ericgig thank you a lot for splitting that PR and giving more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. Test notebooks ran fine. Travis CI tests are ok, besides Mac.
When opening python and importing qutip the first time, I get the warnings
|
Benchmarking
all seem consistent with previous notebook results. Time Benchmarking I am on Python 3.7.3, I recently updated OS from High Sierra to Mojave, plus some other updates in scipy and numpy, and reinstalled conda, so I am curious to see if these speedups are machine independent, which would be great. My specs
Some details: Also, the benchmarking of the different methods now reads
instead of
Minor issue: plots breaking notebook rendering
but not always. Maybe we can have a look at this minor issue in the development notebooks. Documentation Congratulations @Ericgig for this refurbishment, improvement, optimization and thorough benchmarking investigations of the stochastic solvers, which I hope will be widely tested by @nwlambert @ajgpitch @quantshah (and @fminga) for robustness once merged in the development master branch. I am merging this and the montecarlo split PR, hoping there are no incompatibility issues (#990 --> #991 --> #969). |
This PR is part of PR #969 , splitting that PR in two parts.
It contains:
qobjevo
's args that update with the state. (replacing rhs_with_state functionality)norm
renamed to_cdc
as it was not used as a norm.isherm
as an arguments.H
as a function withbatch
method.propagator
usessesolve
capability to evolve operators.sesolve
instead ofmesolve
with no collapse.