Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsetting custom nvim binary does not work #1022

Closed
p3palazzo opened this issue Nov 27, 2023 · 11 comments
Closed

Unsetting custom nvim binary does not work #1022

p3palazzo opened this issue Nov 27, 2023 · 11 comments

Comments

@p3palazzo
Copy link

p3palazzo commented Nov 27, 2023

Expected behavior: Deleting the contents of the Settings > Advanced > Neovim Binary text field should unset the custom nvim binary.

Actual behavior: The settings reverts to the last contents of the Neovim Binary field. Only manually editing the ~/Library/Preferences/com.qvacua.VimR.plist file manages to unset this customization.

Additionally, using the Homebrew nvim binary version 0.9.4 as the custom Neovim Binary does not work and results in a blank window in vimr.

Version 0.45.0 (20231122.130444)

@georgeharker
Copy link
Collaborator

Thanks for the report. That should be throwing up an alert saying incompatible version (upstream fixes were needed for this to work which are in newer versions) can you let me know if that alert shows. We will look at why unsettling doesn’t work.

@zornme
Copy link

zornme commented Nov 29, 2023

I am having the same issue and wanted to chime in to say that the alert does not show. VimR hangs at load and then after a few seconds displays the blank screen. I've attached a screenshot as well. Thank you for all of your work on this project.

image

@p3palazzo
Copy link
Author

Exactly, that's my experience, too. No alert and just the blank window after a few seconds at startup.

@qvacua
Copy link
Owner

qvacua commented Nov 29, 2023

I'm afraid, I cannot reproduce the issue. I'm not sure, but, I made a small change which might fix the issue. Can you please try https://github.com/qvacua/vimr/releases/tag/snapshot%2F20231129.173509 ?

@qvacua
Copy link
Owner

qvacua commented Nov 29, 2023

BTW: @p3palazzo : Which version of macOS are you using?

@p3palazzo
Copy link
Author

Ventura with the latest updates applied.

@qvacua
Copy link
Owner

qvacua commented Nov 29, 2023

@p3palazzo : My guess is that I cannot reproduce it due to a subtle difference between macOS versions; I'm on Sonoma. If my guess is right, the new snapshot above should fix the issue: Please try it.

@p3palazzo
Copy link
Author

Now it clears the path to the incompatible nvim binary on quit and relaunch, which solves the blank window problem, but still doesn't throw any alert.

@georgeharker
Copy link
Collaborator

I’ll take a look at the alert side.

@georgeharker
Copy link
Collaborator

I have some fixes for getting an incompatible version alert to show (it's a bit complex as older neovim without the upstream fix we submitted will block io until a connection is made on stdin, but we should have something soon.

@qvacua
Copy link
Owner

qvacua commented Dec 11, 2023

@qvacua qvacua closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants