let upstream middleware (e.g. fastcgi and cgi) know about authenticated user #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smancke could you please review this PR? It would be great if it could be added in a new release. |
greyarch
added a commit
to greyarch/loginsrv
that referenced
this pull request
Oct 10, 2019
let upstream middleware (e.g. fastcgi and cgi) know about authenticated user
greyarch
added a commit
to greyarch/loginsrv
that referenced
this pull request
Oct 10, 2019
let upstream middleware (e.g. fastcgi and cgi) know about authenticated user
greyarch
added a commit
to greyarch/loginsrv
that referenced
this pull request
Oct 10, 2019
let upstream middleware (e.g. fastcgi and cgi) know about authenticated user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Tested on Windows 7 x64 with PHP 7.3.0 and it sets value for $_SERVER['REMOTE_USER']. This value is empty when user isn't logged in.
Implemented like Caddy's basicauth:
https://github.com/mholt/caddy/blob/master/caddyhttp/basicauth/basicauth.go#L80
I tried adding tests, but I've not been able to for now.