Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change code base from Java to Kotlin #17

Open
sanpei3 opened this issue Feb 28, 2022 · 5 comments
Open

change code base from Java to Kotlin #17

sanpei3 opened this issue Feb 28, 2022 · 5 comments

Comments

@sanpei3
Copy link

sanpei3 commented Feb 28, 2022

The latest AOSP deskclock is written in Kotlin.
Do you have any plan to change the codebase from Java to Kotlin?

Currently, I'm working with Kotlin and I extended some features("exclude holiday" alarm time, selectable alarm notification)
https://github.com/sanpei3/new-clock
(build environment is based from qw123wh/newclock, codebase from Kotlin/AOSP deskclock).

@qw123wh
Copy link
Owner

qw123wh commented Feb 28, 2022

Hi I noticed your fork, it's very interesting, I was thinking of converting the code to Kotlin, but I want to make sure that the “power off alarm” feature also works with the conversion to Kotlin. Other features are also to be tested and you have to see if I also encounter any errors in the compilation phase

@sanpei3
Copy link
Author

sanpei3 commented Mar 2, 2022

That's sounds good. I will test your branch and I will create pull requests. If you create a test branch, please let me know.

@kia1349
Copy link

kia1349 commented Jun 1, 2022

There are many similar programs on the Internet with Kotlin language. But this is the best open source program written in Java. Please do not switch to Kotlin .

@qw123wh
Copy link
Owner

qw123wh commented Jun 1, 2022

@kia1349 My intention is not to delete the java version, but to create another kotlin branch. However I haven't had time to create the kotlin branch yet.
When I have created the kotlin branch I will notify @sanpei3

@kia1349
Copy link

kia1349 commented Jun 6, 2022

🙏👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants