Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize bug by updating xterm-addon-fit #72

Closed
z0rb opened this issue Feb 28, 2023 · 2 comments
Closed

Fix resize bug by updating xterm-addon-fit #72

z0rb opened this issue Feb 28, 2023 · 2 comments

Comments

@z0rb
Copy link

z0rb commented Feb 28, 2023

Hi,

I had issues resizing the terminal after updating ng-terminal to the latest version. After a long while I found the bug responsible for it: xtermjs/xterm.js#4344

After updating xterm-addon-fit to 0.7.0, ng-terminal resized properly again. Can you upgrade the dependency so everyone gets the fix?

@qwefgh90
Copy link
Owner

qwefgh90 commented Mar 1, 2023

Hello.

Thank you for letting me know the issue. I made a commit to bump up the xterm-addon-fit version to 0.7.0 and published new release 5.5.0.

I'm not sure new release's working well.
If you need any support, please make a comment.

@z0rb
Copy link
Author

z0rb commented Mar 1, 2023

Thanks! I removed the dependency override and tested with the new version, all good.

@z0rb z0rb closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants