Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal no longer resizing with fit addon #4344

Closed
AndreSilva1993 opened this issue Dec 21, 2022 · 4 comments
Closed

Terminal no longer resizing with fit addon #4344

AndreSilva1993 opened this issue Dec 21, 2022 · 4 comments

Comments

@AndreSilva1993
Copy link

AndreSilva1993 commented Dec 21, 2022

The terminal no longer fits the container when using the xterm-fit-addon neither fires the onResize callback. On 5.0.0, this was not an issue

Details

  • Browser and browser version: Chrome Version 108.0.5359.124 (Official Build) (arm64)
  • OS version: macOS Ventura 13.1
  • xterm.js version: 5.1.0
  • xterm-addon-fit version: 0.6.0

Steps to reproduce

Created a codesandbox in which the onResize callback is not being called and the terminal is not correctly fitting within its container.

https://codesandbox.io/s/optimistic-jasper-6ny5n4?file=/src/App.js

If one downgrades the version of xterm.js to 5.0.0 the terminal is correctly resized to fit.

@jerch
Copy link
Member

jerch commented Dec 21, 2022

Due to an error during the release build, version numbers of some addons were stuck. The newer addon version 0.7.0 should work again.

@AndreSilva1993
Copy link
Author

@jerch makes sense, will you be releasing that version soon?

@jerch
Copy link
Member

jerch commented Dec 21, 2022

Its already there 😺

@AndreSilva1993
Copy link
Author

Can confirm it works, will close this then. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants