Vertical模式下pageIndicatorColor没有关联hasPrev和hasNext

[AlienKevin]

Fire/Fire/CandidatesView.swift

Lines 128 to 151 in ede5b06

	Image("arrowUp")
	.renderingMode(.template)
	.resizable()
	.frame(width: 10, height: 10, alignment: .center)
	.rotationEffect(Angle(degrees: -90), anchor: .center)
	.onTapGesture {
	if !hasPrev { return }
	NotificationCenter.default.post(
	name: Fire.prevPageBtnTapped,
	object: nil
	)
	}
	Image("arrowDown")
	.renderingMode(.template)
	.resizable()
	.frame(width: 10, height: 10, alignment: .center)
	.rotationEffect(Angle(degrees: -90), anchor: .center)
	.onTapGesture {
	if !hasNext { return }
	print("next")
	NotificationCenter.default.post(
	name: Fire.nextPageBtnTapped,
	object: nil
	)

建议extract出来一个function给vertical和horizontal共用，这样就可以避免新功能out of sync的问题。这是一种写法：

var _indicator: some View {
        let arrowUp = getIndicatorIcon(imageName: "arrowUp", direction: direction, activeFlag: hasPrev, eventName: State.prevPageBtnTapped)
        let arrowDown = getIndicatorIcon(imageName: "arrowDown", direction: direction, activeFlag: hasNext, eventName: State.nextPageBtnTapped)
        if direction == CandidatesDirection.horizontal {
            return AnyView(VStack(spacing: 0) { arrowUp; arrowDown })
        } else {
            return AnyView(HStack(spacing: 4) { arrowUp; arrowDown })
        }
    }
    
    func getIndicatorIcon(imageName: String, direction: CandidatesDirection, activeFlag: Bool, eventName: Notification.Name) -> some View {
        return Image(imageName)
            .renderingMode(.template)
            .resizable()
            .frame(width: 10, height: 10, alignment: .center)
            .rotationEffect(Angle(degrees: direction == CandidatesDirection.horizontal ? 0 : -90), anchor: .center)
            .onTapGesture {
                if !activeFlag { return }
                NotificationCenter.default.post(
                    name: eventName,
                    object: nil
                )
            }
            .foregroundColor(Color(activeFlag
                                   ? themeConfig[colorScheme].pageIndicatorColor
                                   : themeConfig[colorScheme].pageIndicatorDisabledColor
                                  ))
    }

[qwertyyb]

再次感谢你的反馈 🙏