Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge) Make the badge more accessible #292

Closed
tleperou opened this issue May 4, 2023 · 3 comments
Closed

feat(badge) Make the badge more accessible #292

tleperou opened this issue May 4, 2023 · 3 comments

Comments

@tleperou
Copy link
Contributor

tleperou commented May 4, 2023

Summary

Badges shall use by default status role and content flow DOM elements.

Such implementation helps follow the WAI ARIA and HTML practices:

<span class="..." role="status"><Slot /></span>

Concerns

  • we could let integrators customise the role
@fmgono
Copy link

fmgono commented May 17, 2023

So, this is just replacing the div element with span and adding the role attribute?
Appreciate it if you can let me take this one then.

*This will be my first contribution to the Qwik open-source project

@tleperou
Copy link
Contributor Author

That's correct @fmgono 👌

fmgono added a commit to fmgono/qwik-ui that referenced this issue May 17, 2023
@fmgono
Copy link

fmgono commented May 17, 2023

working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants