Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a11y work in the CI and jest cli #308

Closed
shairez opened this issue May 17, 2023 · 4 comments · Fixed by #323
Closed

make a11y work in the CI and jest cli #308

shairez opened this issue May 17, 2023 · 4 comments · Fixed by #323
Assignees
Milestone

Comments

@shairez
Copy link
Contributor

shairez commented May 17, 2023

currently the a11y tests run when storybook is opened, but not on CI

@shairez shairez self-assigned this May 17, 2023
@shairez shairez added this to the 1.0 - Beta milestone May 17, 2023
@kjugi
Copy link

kjugi commented May 18, 2023

It is possible to run i.e. py11y-ci but that would run on the docs/headless/* and docs/tailwind/*pages after generating a sitemap. Ideally, the test should check only the component instead the whole page. In that case, I wonder if it's possible without modifying or creating a preview just to see the component. Are there any limitations there?

Also, what accessibility standard should be taken as default?

In jest cli case - I can try to add https://github.com/nickcolley/jest-axe if that suits the lib needs

@shairez
Copy link
Contributor Author

shairez commented May 22, 2023

thanks @kjugi !

We tried to run the storybook interaction tests using test-storybook but we ran into some nasty issues with jest + TS (+ vite stuff).

So we decided to try cypress for component testing, which can also handle the a11y testing.

The progress is in #323
DM me on discord if you want to join that effort

Thanks again!

@shairez shairez reopened this May 24, 2023
@shairez
Copy link
Contributor Author

shairez commented May 24, 2023

still need to connect it to CI

@shairez
Copy link
Contributor Author

shairez commented May 31, 2023

fixed by #328

@shairez shairez closed this as completed May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants