Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Tooltip component #310

Open
3 of 4 tasks
shairez opened this issue May 17, 2023 · 4 comments
Open
3 of 4 tasks

Finalize Tooltip component #310

shairez opened this issue May 17, 2023 · 4 comments
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request
Milestone

Comments

@shairez
Copy link
Contributor

shairez commented May 17, 2023

  • Has docs
  • Covered by component tests
  • Passes a11y tests
  • Fully featured
@shairez shairez added this to the 1.0 - Beta milestone May 17, 2023
gilf added a commit that referenced this issue Jun 5, 2023
Added spec to tooltip and fixed the documentation

#310
gilf added a commit that referenced this issue Jun 5, 2023
Added spec to tooltip and fixed the documentation

#310
@osdiab
Copy link

osdiab commented Apr 22, 2024

Looking at the tooltip component, it looks like it demands that the tooltip contents have to be a string and cannot be other content (e.g. what would I do if I, say, wanted to put an icon inside the tooltip?)

Personally I think it would make sense to allow the rendered content to be provided with (or overridden by) a Slot to achieve similar flexibility as mature libraries like Radix, though what do you think?

@osdiab
Copy link

osdiab commented Apr 24, 2024

Sounds like this is basically outdated and to be superseded by a rewrite to make the Tooltip be implemented with Popovers.

#714 (comment)
#713 (comment)
#714 (comment)

@thejackshelton should we use this as the issue to track reimplementation of the tooltip or should it be a separate new issue?

@thejackshelton
Copy link
Contributor

thejackshelton commented Apr 24, 2024

whatever you prefer. we can keep it here if you'd like @osdiab

@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

Let's keep this issue. The tooltip needs more work.

@maiieul maiieul added COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels May 31, 2024
@shairez shairez added the TYPE: enhancement New feature or request label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants