Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GNOME 46 #130

Merged
merged 1 commit into from Mar 26, 2024
Merged

Update to GNOME 46 #130

merged 1 commit into from Mar 26, 2024

Conversation

prapooskur
Copy link
Contributor

Gnome 46 deprecates add_actor and actor-added. This PR replaces uses of them with add_child and child-added.
This is my first time working on an extension, so let me know if I did anything incorrectly!

@qwreey
Copy link
Owner

qwreey commented Mar 15, 2024

I will test this on 45!

@loveisfoss
Copy link

loveisfoss commented Mar 20, 2024

@prapooskur I am also a newbie with extensions and I understand changing actor-added with actor-child. I wonder, though, why you changed add with add_child in VolumeMixerHandler.js

@Neo-29
Copy link

Neo-29 commented Mar 24, 2024

Hi,

For the moment it's not working on gnome 46
Have you planned a portage?

Tks a lot

@qwreey qwreey merged commit 79e3013 into qwreey:master Mar 26, 2024
@qwreey
Copy link
Owner

qwreey commented Mar 26, 2024

I checked these codes working fine as expected. Thank you for your contribution!

@Anuskuss Anuskuss mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants