Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QXmppPresence, Add missing tests #231

Merged
merged 1 commit into from Dec 10, 2019

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Nov 22, 2019

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #231 into master will increase coverage by 0.17%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   68.27%   68.44%   +0.17%     
==========================================
  Files         190      191       +1     
  Lines       16598    16630      +32     
==========================================
+ Hits        11332    11383      +51     
+ Misses       5266     5247      -19
Impacted Files Coverage Δ
src/base/QXmppPresence.h 100% <ø> (ø)
tests/qxmpppresence/tst_qxmpppresence.cpp 100% <100%> (ø) ⬆️
src/base/QXmppPresence.cpp 93.42% <97.16%> (+8.25%) ⬆️
src/base/QXmppElement.cpp 80.86% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40b65c...c7de8a5. Read the comment docs.

@lnjX lnjX changed the title WIP: Refactor QXmppPresence + 100% tests Refactor QXmppPresence, Add missing tests Dec 10, 2019
@lnjX lnjX merged commit 4d61ddd into qxmpp-project:master Dec 10, 2019
@lnjX lnjX deleted the refactor/qxmpppresence branch December 10, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant