Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing QXmppGlobal.h for static linking #299

Merged
merged 2 commits into from May 18, 2020
Merged

Fixing QXmppGlobal.h for static linking #299

merged 2 commits into from May 18, 2020

Conversation

leobasilio
Copy link
Contributor

Following the discussion on issue #297, here's my attempt to solve it.

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #299 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   75.54%   76.02%   +0.48%     
==========================================
  Files         205      205              
  Lines       17130    17131       +1     
==========================================
+ Hits        12941    13024      +83     
+ Misses       4189     4107      -82     
Impacted Files Coverage Δ
src/base/QXmppLogger.h 9.09% <0.00%> (-72.73%) ⬇️
src/client/QXmppRemoteMethod.h 0.00% <0.00%> (ø)
src/base/QXmppStanza_p.h 91.83% <0.00%> (+91.83%) ⬆️
src/base/QXmppBitsOfBinaryDataList.h 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe83e9c...d8a05fb. Read the comment docs.

@lnjX
Copy link
Member

lnjX commented May 18, 2020

Thanks for the PR. :)
I added a commit that makes this less hacky by adding a proper variable in cmake. Can you confirm that this still works all properly?

@leobasilio
Copy link
Contributor Author

Thanks for the fix. I'm really not that experienced with cmake. Just tried to be the least intrusive as possible. From what I can tell, it's working perfectly. 👍

@lnjX lnjX merged commit 2ba4d79 into qxmpp-project:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants