Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XEP-0447: Stateless file sharing: File sharing element #448

Merged
merged 10 commits into from Sep 13, 2022

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Sep 5, 2022

Implements parsing for the file sharing element from XEP-0447:
Stateless files sharing version 0.2.

https://xmpp.org/extensions/xep-0447.html

PR check list:

  • Document your code
  • Add \since QXmpp 1.X, QXMPP_EXPORT
  • Fix doxygen warnings (see log when building with -DBUILD_DOCUMENTATION=ON)
  • Update doc/xep.doc
  • Add unit tests
  • Format the code: Run clang-format -i src/<edited-file(s)> tests/<edited-file(s)>

@jbruechert jbruechert force-pushed the feature/sfs-element-parsing branch 2 times, most recently from d84e736 to eb14ec0 Compare September 5, 2022 21:03
@lnjX lnjX force-pushed the feature/sfs-element-parsing branch 2 times, most recently from 442f6a4 to 0126878 Compare September 5, 2022 22:16
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #448 (dcf67ce) into master (321a5d9) will increase coverage by 0.89%.
The diff coverage is 68.33%.

❗ Current head dcf67ce differs from pull request most recent head 7779427. Consider uploading reports for the commit 7779427 to get more accurate results

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   68.15%   69.05%   +0.89%     
==========================================
  Files         271      269       -2     
  Lines       23822    23684     -138     
==========================================
+ Hits        16235    16354     +119     
+ Misses       7587     7330     -257     
Impacted Files Coverage Δ
...mple_2_rosterHandling/example_2_rosterHandling.cpp 0.00% <0.00%> (ø)
..._3_transferHandling/example_3_transferHandling.cpp 0.00% <0.00%> (ø)
examples/example_6_rpcClient/rpcClient.cpp 0.00% <0.00%> (ø)
...le_7_archiveHandling/example_7_archiveHandling.cpp 0.00% <0.00%> (ø)
examples/example_9_vCard/example_9_vCard.cpp 0.00% <0.00%> (ø)
src/base/QXmppBookmarkSet.cpp 0.00% <0.00%> (ø)
src/base/QXmppHttpUploadIq.cpp 100.00% <ø> (ø)
src/base/QXmppMessage.h 100.00% <ø> (ø)
src/base/QXmppPubSubNodeConfig.cpp 49.66% <0.00%> (ø)
src/client/QXmppArchiveManager.cpp 0.00% <0.00%> (ø)
... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/base/QXmppMessage.cpp Outdated Show resolved Hide resolved
src/base/QXmppMessage.cpp Outdated Show resolved Hide resolved
@lnjX lnjX force-pushed the feature/sfs-element-parsing branch from cc43495 to 377aaeb Compare September 13, 2022 21:07
@lnjX lnjX merged commit a780d36 into qxmpp-project:master Sep 13, 2022
@lnjX lnjX deleted the feature/sfs-element-parsing branch September 13, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants