Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bugs in code, thanks for your excellent work #2

Closed
yanliang3612 opened this issue Nov 30, 2023 · 2 comments
Closed

some bugs in code, thanks for your excellent work #2

yanliang3612 opened this issue Nov 30, 2023 · 2 comments

Comments

@yanliang3612
Copy link
Contributor

Dear CBDM' authors,

Thank you for your patience and for providing the essential details about the project code. I have great respect and high admiration for your work, it is truly influential.

I wanted to highlight some issues I encountered while attempting to use the code released on GitHub. Specifically, in main.py at line 392, the FLAGS.rho parameter seems to be unrecognized. Additionally, I suggest adding a comment on line 129 of score\both.py to prevent potential execution errors.

While these issues have hindered the immediate usability of the code, I remain enthusiastic and appreciative of your work. It would be immensely helpful if the code on GitHub could be updated, or if additional guidance could be provided to address these concerns.

Thank you once again for your efforts and for sharing your work. I look forward to your response.

@yanliang3612
Copy link
Contributor Author

I have fixed the bug and release the code and submit pull requests in the github, if you think the code is working, you can merge the pull requests. Thanks.

@qym7
Copy link
Owner

qym7 commented Nov 30, 2023

Thanks for your work and comment! Your merging request has been approved.

@qym7 qym7 closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants