Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does pyxtal work with pyshtools==4.10.3 ? #222

Closed
jan-janssen opened this issue Jun 29, 2023 · 2 comments
Closed

Does pyxtal work with pyshtools==4.10.3 ? #222

jan-janssen opened this issue Jun 29, 2023 · 2 comments

Comments

@jan-janssen
Copy link

I see that pyshtools==4.10 is restricted, but I do not really understand why.
@jan-janssen jan-janssen mentioned this issue Jun 29, 2023
Merged
@qzhu2017
Copy link
Owner

@jan-janssen PyXtal used the numba library for XRD calculation. At some point, it created some conflicts with the pyshtools>=v4.10. Hence I intentionally restricted the use of pyxshtools==v4.10. I will lift this restriction if it no longer creates the conflict.

qzhu2017 added a commit that referenced this issue Jul 8, 2023
@qzhu2017
check if pyshtools is compatible #222
c84e90c
@qzhu2017
Copy link
Owner

qzhu2017 commented Jul 8, 2023

I have removed the constraint since pyshtools is now compatible.

@qzhu2017 qzhu2017 closed this as completed Jul 8, 2023
@sgbaird sgbaird mentioned this issue Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jan-janssen @qzhu2017