Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox certificates not being deleted #252

Closed
tresf opened this issue Oct 25, 2017 · 0 comments
Closed

Firefox certificates not being deleted #252

tresf opened this issue Oct 25, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@tresf
Copy link
Contributor

tresf commented Oct 25, 2017

We currently use an ill-advised but previously working technique for removing QZ Tray SSL certificates from Firefox by searching by nickname using findCertByNickname. At some point, this technique broke, newer Firefox versions don't seem to support this technique. There's also a API for searching by email (findCertByEmailAddress), but that seems to be broken as well so we'll have to find it manually.

The newly proposed method is to manually iterate over all certificates and purge those with support@qz.io in the email address.

Sample autoconfig code:

var certdb = getCertDB();
var certs = certdb.getCerts();
var enumerator = certs.getEnumerator();
while (enumerator.hasMoreElements()) {
   var cert = enumerator.getNext().QueryInterface(Components.interfaces.nsIX509Cert);
   if(cert.containsEmailAddress ("${vendor.email}")) {
      certdb.deleteCertificate(cert);
   }
}

Next, the various installer would need to pass vendor.email in as a replacement string.
* Linux/Apple
* Windows

Edit: We should be safe without touching the cert logic since ant will configure this email address at packaging time.

@tresf tresf added the bug label Oct 25, 2017
@tresf tresf added this to the 2.0.5 milestone Oct 25, 2017
@tresf tresf self-assigned this Oct 25, 2017
tresf added a commit that referenced this issue Oct 26, 2017
tresf added a commit that referenced this issue Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant