Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing says "complete" in the logs but job's "complete" event hasn't fired #974

Open
tresf opened this issue May 24, 2022 · 2 comments
Open
Assignees

Comments

@tresf
Copy link
Contributor

tresf commented May 24, 2022

When the "PRINTED" event fires from Wmi, it will send the "COMPLETE" status back to the API.

PRINTED(NativeJobStatus.COMPLETE, 0x00000080), // Job has printed

Unfortunately, we use near identical nomenclature when the job is accepted by the spooler:

log.info("Printing complete");

The above can cause confusion when a developer is monitoring job data from both the logs and the API.

@Vzor-
Copy link
Contributor

Vzor- commented Jul 6, 2022

Maybe it would make more sense to say log.info("Print started") or log.info("Job started")

At that point we only really know the job has been uploaded to a buffer somewhere, be it in a spooler or direct to a hardware buffer.

@tresf
Copy link
Contributor Author

tresf commented Jul 7, 2022

@Vzor- how about

log.info("Print job spooled successfully"); 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants