Added basic accessibility #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234
We could use
System.setProperty("javax.accessibility.assistive_technologies", "");to avoid issues with accessibility by completely removing the feature, even when enabled globally on the system. That was my initial solution, and to enable accessibility using a build flag. Originally I was concerned about the security implications of the JAB (Java Access Bridge) which is used to communicate accessibility information on windows. After reading a bit on the topic though, I believe the JAB is safe, and decided to instead support it.I tested it with the NVDA screen reader, as JAWS requires a license, and Windows Narrator seems to be completely blind to swing. There were a few issues, such as our 'LinkLabel' not being selectable with tab. Some issues still exist, such as our tables capture the cursor when tabbing, and don't allow it to escape. This is observable on our 'View Request Details' window.