New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various HID Improvements #289
Conversation
+ ensure PJHA buffered bytes are copied and limit buffer size
I've begun testing the
UPDATE: Steps to reproduce:
Here is the stacktrace.
|
@klabarge I can't reproduce on my machine. Was this with |
Okay, so I was able to figure out reproducible steps. Patience was they key...
Here is the
|
After further testing, this crash is reproducible on 2.0.5 and 2.0.4-1. The crashing does not seem to be due to anything in this patch. |
Some important improvements to HID:
Provides two new parameters to the
qz.hid.claimDevice
and friends...usagePage
: Allows devices such as the Honewell Barcode scanners to be claimed per Can't read data from Honeywell Scanner #288.serial
: Allows multiple identical devices to be attached to the same computer by providingserial
parameter.Provides a byte buffer for streaming HID data on Windows per HID Windows Truncates Data #286.
This PR affects the API. Backwards compatibility is maintained, but the
qz.hid.claimDevice
signature has been changed:Before:
After:
This has some added benefits, mainly, a "device" object can be passed directly from
qz.hid.listDevices
directly intoqz.hid.claimDevice
. The wiki does not yet spell this out. This feature is available in QZ Tray 2.0.6 and higher.Closes #286, #288