-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BitwiseAND and BitwiseOR on HOST and HIP #230
Merged
r-abishek
merged 19 commits into
r-abishek:ar/opt_bitwise_and_or
from
snehaa8:sn/bitwise_OR
Mar 6, 2024
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3debd2f
Initial commit - Bitwise AND HOST Tensor
snehaa8 569ad14
Match u8 and i8 outputs with BatchPD variant
snehaa8 8c68c8a
Fix i8 PKD3 -> PLN3
snehaa8 562c336
Initial commit - Bitwise AND HIP Tensor
snehaa8 d03f07a
Add reference outputs
snehaa8 d12870a
Merge branch 'master' of https://github.com/ROCm/rpp into sn/bitwise_AND
snehaa8 5e524f7
Modify reference outputs
snehaa8 5e4b736
Combine templated functions to support all datatypes
snehaa8 ac88212
Initial commit - Bitwise OR HOST
snehaa8 97b9aa1
Fix GPU kernel details
snehaa8 557d8d4
Merge branch 'sn/bitwise_AND' of https://github.com/snehaa8/rpp into …
snehaa8 226bf9d
Fix case number for HOST testsuite
snehaa8 3df2c11
Initial commit - Bitwise OR HIP
snehaa8 1590f34
Address review comments
snehaa8 3246085
Merge branch 'ar/opt_bitwise_and_or' into sn/bitwise_OR
snehaa8 860b853
Update rppt_tensor_arithmetic_operations.h
r-abishek 304fc09
Update rppt_tensor_arithmetic_operations.h
r-abishek ea89580
Merge branch 'develop' of https://github.com/ROCm/rpp into sn/bitwise_OR
snehaa8 e4c6388
Move bitwise operations into under logical ops
snehaa8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have the 0,3,6,9 mask or the 0,4,8,12 mask pre-allocated outside of the runtime execution path somewhere since they are common?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked this while implementing, didn't find any in the fashion I needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should i add this at the start of rpp_cpu_simd where other common constants are defined?