Audio support in RPP - HOST #78
Conversation
sampath1117
commented
Jun 23, 2022
•
sampath1117
commented
- Added support for below audio functions in RPP for HOST backend
- Non Silent Region detection
- Pre Emphasis
- To Decibels
- Down Mixing
- Slice
- Spectrogram
- MelFilterBank
- Resample
- Added basic test suite for testing audio functions
made changes to test .wav files for nsr detection
minor cleanup
added sample test suite for audio files
added sample audio file in seperate folder
minor changes in the ways weights are being accesed
removed redundant audio codes
… region updated CMakeLists.txt in src/modules to exclude fma compilation flag for audio codes
| #include <chrono> | ||
| #include <complex> | ||
|
|
||
| inline Rpp32f reduce_add_ps1(__m256 pSrc) |
There was a problem hiding this comment.
Can be renamed as rpp_horizontal_add_avx and move to L280 in rpp_cpu_simd.hpp
https://github.com/sampath1117/rpp/blob/sr/audio_augmentations/src/include/cpu/rpp_cpu_simd.hpp#L271
| { | ||
| Rpp32f* cosfTemp = cosf + (k * nfft); | ||
| Rpp32f* sinfTemp = sinf + (k * nfft); | ||
| __m256 pJN = _mm256_set_ps(7,6,5,4,3,2,1,0); |
There was a problem hiding this comment.
What does JN mean here?
Can we rename it to more intuitive name?
| { | ||
| Rpp32f* cosfTemp = cosf + (k * nfft); | ||
| Rpp32f* sinfTemp = sinf + (k * nfft); | ||
| __m256 pJN = _mm256_set_ps(7,6,5,4,3,2,1,0); |
There was a problem hiding this comment.
Please add space after , Can be changed as
__m256 pJN = _mm256_set_ps(7, 6, 5, 4, 3, 2, 1, 0);
Applicable to all such instances in this file
| Rpp32f* sinfTemp = sinf + (k * nfft); | ||
| __m256 pJN = _mm256_set_ps(7,6,5,4,3,2,1,0); | ||
| __m256 pMulFactorN = _mm256_set1_ps(k*mulFactor); | ||
| __m256 pAddFactorN = _mm256_set1_ps(8); |
There was a problem hiding this comment.
Can use avx_p8 defined rpp_cpu_simd.hpp
https://github.com/sampath1117/rpp/blob/sr/audio_augmentations/src/include/cpu/rpp_cpu_simd.hpp#L99
Instead of using _mm256_set1_ps(8)
| __m256 pMulFactorN = _mm256_set1_ps(k*mulFactor); | ||
| __m256 pAddFactorN = _mm256_set1_ps(8); | ||
| Rpp32s i = 0; | ||
| for (; i < alignedNfftLength; i += 8) { |
There was a problem hiding this comment.
We can follow current RPP style for brackets for now
bracket in next line like below
for (; i < alignedNfftLength; i += 8)
{
Applicable to all such instances in this file
| __m256 pAddFactorN = _mm256_set1_ps(8); | ||
| Rpp32s i = 0; | ||
| for (; i < alignedNfftLength; i += 8) { | ||
| __m256 pSrc = _mm256_mul_ps(pJN,pMulFactorN); |
There was a problem hiding this comment.
Please add space after ,
Please go through entire file and update instances like this
| *sinfTemp++ = -std::sin(k * i * mulFactor); | ||
| } | ||
| } | ||
| std::vector<Rpp32f> windowFn; |
There was a problem hiding this comment.
We can add empty lines between 2 logical code blocks similar to here
We are computing sin and cos values from L91 to L102 which is one logical code block and codes from L103 is another code block, So we can add empty line here
Please add empty lines to all such cases in this file
| *windowOutputTemp++ = (*windowFnTemp++) * (*srcPtrWindowTemp++); | ||
| } | ||
| } | ||
| // Generate specgram output |
There was a problem hiding this comment.
We can add blank line before L164
| if (power == 1) | ||
| total = std::sqrt(total); | ||
| if (vertical) { | ||
| int64_t outIdx = (i * hStride + w); |
There was a problem hiding this comment.
Please replace int64_t with Rpp64s
