Solve error with rgeos::createSPComment() #49
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the main error was with createSPComment() while creating the sp SpatialPolygons. I changed mainly dg_process_polydata() to work with sf and convert to sp Spatial later.
I had to repeat the first point of each cell to be able to close the grid cells.
x <- rbind(x, x[1,])
I also corrected the license NOTE.
I still get some other NOTEs on the package size but only that