Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classes to wt_() returns #3

Closed
malcolmbarrett opened this issue Mar 10, 2023 · 2 comments
Closed

Add classes to wt_() returns #3

malcolmbarrett opened this issue Mar 10, 2023 · 2 comments

Comments

@malcolmbarrett
Copy link
Collaborator

important weights class from tidymodels + a class to indicate the type of weight, e.g. ato_weight, which can help us indicate which sandwich estimator to fit

cc @simonpcouch because this idea came from your code. In other words, we can move the step of indicating this is a weight we can use in tidymodels to propensity

@simonpcouch
Copy link

Stoked to hear you're motivated to tighten that integration. :)

Wanted to note that our current drafts of machinery introducing support for propensity take care of that conversion under the hood.

@malcolmbarrett
Copy link
Collaborator Author

Cool, I think that will work a bit better since the importance weights class object turned out to be difficult to work with in other ways we use them

@malcolmbarrett malcolmbarrett closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants