Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in has_completed_statement #176

Closed
dernst opened this issue Mar 8, 2019 · 2 comments
Closed

typo in has_completed_statement #176

dernst opened this issue Mar 8, 2019 · 2 comments

Comments

@dernst
Copy link

dernst commented Mar 8, 2019

spec_meta_has_completed$has_completed_statement currently calls dbSendQuery instead of dbSendStatement. I assume this is a typo since the comment inside this function also implies dbSendStatement should be called.
@hannes
Copy link

hannes commented Mar 12, 2019

Orr i was doubting myself already

@krlmlr
Copy link
Member

krlmlr commented Mar 17, 2019

Good catch, thanks!

@krlmlr krlmlr closed this as completed in b51687b Mar 17, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hannes @dernst @krlmlr