Merge pull request #188 from r-dbi/f-quote-time

- `dbQuoteLiteral()` now correctly quotes difftime values (#188).

R/coerce.R

@@ -34,7 +34,11 @@ string_to_utf8 <- function(value) {
 
 difftime_to_hms <- function(value) {
   is_difftime <- vlapply(value, inherits, "difftime")
-  value[is_difftime] <- lapply(value[is_difftime], hms::as_hms)
+  # https://github.com/tidyverse/hms/issues/84
+  value[is_difftime] <- lapply(value[is_difftime], function(x) {
+    mode(x) <- "double"
+    hms::as_hms(x)
+  })
   value
 }
 

R/quote.R

@@ -105,3 +105,20 @@ setMethod("dbQuoteString", c("MariaDBConnection", "SQL"),
     x
   }
 )
+
+#' @rdname mariadb-quoting
+#' @export
+setMethod("dbQuoteLiteral", signature("MariaDBConnection"),
+  function(conn, x, ...) {
+    # Switchpatching to avoid ambiguous S4 dispatch, so that our method
+    # is used only if no alternatives are available.
+
+    if (inherits(x, "difftime")) return(cast_difftime(callNextMethod()))
+
+    callNextMethod()
+  }
+)
+
+cast_difftime <- function(x) {
+  SQL(paste0("CAST(", x, " AS time)"))
+}