Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbWriteTable ignores field.types param #10

Closed
krlmlr opened this issue Jul 5, 2017 · 4 comments
Closed

dbWriteTable ignores field.types param #10

krlmlr opened this issue Jul 5, 2017 · 4 comments
Milestone
1.0

Comments

@krlmlr
Copy link
Member

krlmlr commented Jul 5, 2017

Issue by pantoniades
Thursday Apr 23, 2015 at 16:33 GMT
Originally opened as r-dbi/RMySQL#67

Passing in a list of field types has no effect on dbWriteTable.

It appears to be that they do not get passed in to the call to DBI::sqlCreateTable on line 92 of table.R

It's a small change, and I am happy to send a pull request.

thanks
@krlmlr krlmlr added this to the 1.0 milestone Jul 5, 2017
@krlmlr
Copy link
Member Author

krlmlr commented Jul 5, 2017

Comment by pantoniades
Wednesday Apr 29, 2015 at 18:28 GMT

Sorry, to be more exact it was that in the dbWriteTable(MySQL(), character, data.frame) form it only passes in the df to the sqlCreateTable() call, so column types are determined regardless of what's in the field.types parameter.

@krlmlr
Copy link
Member Author

krlmlr commented Jul 5, 2017

Comment by jlsepulveda
Tuesday Jun 23, 2015 at 21:29 GMT

Hi pantoniades

I have the same behaviour using dbWriteTable, do you have any update related?

Thanks

@krlmlr
Copy link
Member Author

krlmlr commented Jul 5, 2017

Comment by pantoniades
Wednesday Jun 24, 2015 at 15:45 GMT

Hi,

I fixed it in my own branch - see
pantoniades/RMySQL@e3e9f29
for the changed code.

Philip

@krlmlr krlmlr closed this as completed in f3c179c Sep 9, 2017
krlmlr added a commit that referenced this issue Sep 24, 2017
@krlmlr
Merge tag 'v0.11-7'
56707ab 
- Improve documentation for location of option files, with reference (#18).
- Fully support parametrized queries (#22, #27, #39).
- Use snake_case in C++ code.
- Make transactions compliant to the spec (#38, #49).
- 64-bit integers are now supported through the `bit64` package. Unfortunately, this also means that numeric literals (as in `SELECT 1`) are returned as 64-bit integers (#12).
- Support timestamp values with sub-second precision on output.
- The connection now uses the "utf8mb4" charset by default (#7).
- The `port` and `client.flag` arguments to `dbConnect()` are coerced to integer (#4).
- Date values with the year beyond 2038 are supported (#56).
- Improve DBI compliance (#1, #5, #10, #15, #17, #40).
- Correct handling of DATETIME and TIME columns (#52, @noahwilliamsson).
@github-actions
Copy link

github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@krlmlr