add upsert support with an additonal parameter "onduplicate" #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collect coverage
fix copy-pastie
Replace isnan() with R's ISNAN(), as described in Writing R Extensions: > Functions/macros such as isnan, isinf and isfinite are not required by > C++98: where compilers support them they may be only in the std > namespace or only in the main namespace. There is no way to make use > of these functions which works with all C++ compilers currently in use > on R platforms: use R’s versions such as ISNAN and R_FINITE instead. > -- [R Core Team,Writing R Extensions: Portable C and C++ code] > (https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Portable-C-and-C_002b_002b-code) This prevents the following error when trying to build RMySQL on my Mac OS X 10.7: MyBinding.h:100: error: ‘isnan’ was not declared in this scope Further reading: * https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Portable-C-and-C_002b_002b-code * https://stat.ethz.ch/pipermail/r-devel/2005-January/thread.html#31793 * https://stat.ethz.ch/pipermail/r-devel/2005-January/thread.html#31800 * http://lists.apple.com/archives/Xcode-users/2006/Aug/thrd7.html#00619 * http://lists.apple.com/archives/Xcode-users/2006/Aug/thrd7.html#00633 * http://stackoverflow.com/questions/18128899/is-isnan-in-the-std-namespace-more-in-general-when-is-std-necessary-optio * http://stackoverflow.com/questions/2249110/how-do-i-make-a-portable-isnan-isinf-function * http://stackoverflow.com/questions/570669/checking-if-a-double-or-float-is-nan-in-c
Use ISNAN() to prevent build error on OS X 10.7
|
Thanks for looking into it. The How does this work in PostgreSQL, SQL Server, or Oracle? |
|
+1 Critical Functionality. Appreciate if it can be merged into the package |
|
New features go into the RMariaDB package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should suffice most the use cases as described in #68 and #194.
I'm adding a new parameter instead of replacing "append" to have a better backward compatibility support.