Merge pull request #270 from r-dbi/f-quote-time

- `dbQuoteLiteral()` now quotes difftime values as interval (#270).
r-dbi · Dec 22, 2020 · c3dd048 · c3dd048
2 parents a7d68c6 + 154b109
commit c3dd048
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/R/PqResult.R b/R/PqResult.R
@@ -202,7 +202,11 @@ fix_posixt <- function(value) {
 
 difftime_to_hms <- function(value) {
   is_difftime <- vlapply(value, inherits, "difftime")
-  value[is_difftime] <- lapply(value[is_difftime], hms::as_hms)
+  # https://github.com/tidyverse/hms/issues/84
+  value[is_difftime] <- lapply(value[is_difftime], function(x) {
+    mode(x) <- "double"
+    hms::as_hms(x)
+  })
   value
 }
 

diff --git a/R/quote.R b/R/quote.R
@@ -156,7 +156,10 @@ setMethod("dbQuoteLiteral", c("PqConnection", "POSIXt"), function(conn, x, ...)
 #' @export
 #' @rdname quote
 setMethod("dbQuoteLiteral", c("PqConnection", "difftime"), function(conn, x, ...) {
-  ret <- paste0(as.character(x), "::time")
+  # https://github.com/tidyverse/hms/issues/84
+  mode(x) <- "double"
+
+  ret <- paste0("'", as.character(hms::as_hms(x)), "'::interval")
   ret[is.na(x)] <- "NULL"
   SQL(ret, names = names(ret))
 })