Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement postgresIsTransacting() #351

Merged
merged 9 commits into from Dec 12, 2021
Merged

Implement postgresIsTransacting() #351

merged 9 commits into from Dec 12, 2021

Conversation

jakob-r
Copy link
Contributor

@jakob-r jakob-r commented Oct 21, 2021 •
edited by krlmlr

Closes #349

@jakob-r jakob-r marked this pull request as ready for review October 21, 2021 16:58
@krlmlr
Copy link
Member

krlmlr commented Dec 4, 2021

Thanks. Can you please document the new function in _pkgdown.yml and fix the failing test (expect_fale) ?

@krlmlr krlmlr modified the milestones: 1.4.1, 1.4.2, 1.4.3 Dec 5, 2021
galachad
galachad reviewed Dec 6, 2021
View reviewed changes
R/PqConnection.R Outdated Show resolved Hide resolved
tests/testthat/test-isTransacting.R Outdated Show resolved Hide resolved
tests/testthat/test-isTransacting.R Outdated Show resolved Hide resolved
krlmlr and others added 2 commits December 12, 2021 11:33
@krlmlr
Merge branch 'main' into main
a217c9b
@krlmlr @galachad
Apply suggestions from code review
506ab86 
Co-authored-by: Adam Foryś <adam.forys@gmail.com>
@krlmlr krlmlr merged commit de53077 into r-dbi:main Dec 12, 2021
@krlmlr
Copy link
Member

krlmlr commented Dec 12, 2021

Thanks!

@krlmlr
Copy link
Member

krlmlr commented Dec 12, 2021

One more thing: do you agree to contribute under the MIT license? Please indicate your consent or disapproval in #312. Thanks!

@jakob-r
Copy link
Contributor Author

jakob-r commented Dec 13, 2021

Sorry for the lousy PR and thanks for fixing it :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr left review comments

@galachad galachad galachad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.

Export connection_is_transacting
3 participants
@jakob-r @krlmlr @galachad