Accept uuid types Iss30 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,55 @@ | |||
| context("Convenience Functions") | |||
There was a problem hiding this comment.
The generic functions are now mostly (if not entirely) tested by the DBitest package. I'd be happy to review pull requests for new tests there.
|
@krlmlr Thanks for the feedback. I went through and made those modifications. |
| @@ -280,6 +280,8 @@ class PqResult : boost::noncopyable { | |||
| case 1184: // TIMESTAMPTZOID | |||
| case 1186: // INTERVAL | |||
| case 1266: // TIMETZOID | |||
| case 3802: // JSONB | |||
There was a problem hiding this comment.
This change seems unrelated to the original issue. I would be better to open a new PR for this, but I don't mind including it if you could provide a test.
|
Thanks! The dbDisconnect() should better be in on.exit(), but this doesn't matter too much for the tests. |
|
@krlmlr Thank you for the feedback and help. I really appreciate it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If everyone is ok with uuid types being character classes in R then this is ready to merge.
Fixes #30.