New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New sqliteIsTransacting()
that returns if a transaction is active on the current connection
#462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
sqliteIsTransacting()
that returns if a transaction is active on the current connection
Thanks! |
@bpvgoncalves: 2d4ac14 introduces a problem with the orderly package, found through Other packages fail too with the current main branch. Can you please take a look? My #!/bin/sh
set -ex
git clean -fdx src
R CMD INSTALL .
R -q -e 'rcmdcheck::rcmdcheck("~/git/R/orderly")' |
Hello. I missed this mail last night. I'm really sorry this change broke
something... I'll take a look at it. Best regards.
…On Mon, 12 Jun 2023, 22:29 Kirill Müller, ***@***.***> wrote:
@bpvgoncalves <https://github.com/bpvgoncalves>: 2d4ac14
<2d4ac14>
introduces a problem with the orderly package, found through git bisect.
That package fails R CMD check after this commit.
Other packages fail too with the current main branch. Can you please take
a look?
My test.sh for git bisect :
#!/bin/sh
set -ex
git clean -fdx src
R CMD INSTALL .
R -q -e 'rcmdcheck::rcmdcheck("~/git/R/orderly")'
—
Reply to this email directly, view it on GitHub
<#462 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXBNOPECRKJJY5WS2XWK7DXK533RANCNFSM6AAAAAAYJQEEVI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So... It looks orderly, and possibly other packages, are at some point applying a commit/rollback when no open transactions exists. After applying PR #464 it seem to be fixed. |
In response to issue #453 I implemented a functionality to allow checking of transaction status.
I cannot find any develop branch so the PR targets the main branch.
It passes the tests:
It CMD CHECKs in my local machine (only 1 NOTE unrelated to the changes)
Best Regards