Write Parquet file into a memory buffer #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jun 8, 2024
R/bq-perform.R
Outdated
| @@ -202,15 +202,7 @@ export_json <- function(values) { | |||
| # https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-parquet?hl=es-419 | |||
| export_parquet <- function(values) { | |||
There was a problem hiding this comment.
You could probably drop this wrapper function now 😄
|
This needs dev nanoparquet currently, so until there is a new nanoparquet release on CRAN (soon!), you'll need to add to |
|
Hi @hadley and @gaborcsardi, Thank you for your review, I have taken into account your comments, and I hope I haven't missed any. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hadley,
This pull request aims to eliminate disk writing when PARQUET is selected as the transmission format by the user.
Thanks @gaborcsardi for the new nanoparquet feature
Regards,