Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require R >= 3.0.0 (using 'slots' argument of setClass()) #169

Merged
merged 1 commit into from
Apr 5, 2017
Merged

Require R >= 3.0.0 (using 'slots' argument of setClass()) #169

merged 1 commit into from
Apr 5, 2017

Conversation

mvkorpel
Copy link
Contributor

Package installation fails on R < 3.0.0, tested on R 2.15.2.

@codecov-io
Copy link

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   43.09%   43.09%           
=======================================
  Files          16       16           
  Lines         471      471           
=======================================
  Hits          203      203           
  Misses        268      268

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d8d65...d6a1d3a. Read the comment docs.

@krlmlr krlmlr merged commit 108fc68 into r-dbi:master Apr 5, 2017
@krlmlr
Copy link
Member

krlmlr commented Apr 5, 2017

Thanks!

@mvkorpel mvkorpel deleted the slots branch April 6, 2017 03:53
krlmlr added a commit that referenced this pull request May 5, 2017
- Update specification from DBItest v1.4-21.
- The default implementation of `dbGetQuery()` now accepts an `n` argument and forwards it to `dbFetch()`. No warning about pending rows is issued anymore (#76).
- The `dbGetQuery()` method now has `valueClass = data.frame`.
- Require R >= 3.0.0 (for `slots` argument of `setClass()`) (#169, @mvkorpel).
krlmlr added a commit that referenced this pull request Jun 18, 2017
- Import updated specs from `DBItest`.
- The default implementation of `dbGetQuery()` now accepts an `n`
argument and forwards it to `dbFetch()`. No warning about pending rows
is issued anymore (#76).
- Require R >= 3.0.0 (for `slots` argument of `setClass()`) (#169,
@mvkorpel).
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants