Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using inheritance, not composition #3

Closed
krlmlr opened this issue Apr 8, 2019 · 2 comments
Closed

Consider using inheritance, not composition #3

krlmlr opened this issue Apr 8, 2019 · 2 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Apr 8, 2019

Reason: Otherwise specializations we're not aware of (e.g. dbplyr::db_analyze()) use the default method.

Involves dynamic creation of S4 classes.
@krlmlr krlmlr mentioned this issue Apr 14, 2019
Merged
@krlmlr
Copy link
Member Author

krlmlr commented Dec 17, 2019

Works well enough for now.

@krlmlr krlmlr closed this as completed Dec 17, 2019
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlmlr