Skip to content

Commit

Permalink
[feat #457] update npm scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
r-hannuschka committed Dec 31, 2021
1 parent ca56d5c commit 3ba38a5
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
3 changes: 0 additions & 3 deletions package-lock.json

This file was deleted.

4 changes: 3 additions & 1 deletion src/package.json
Expand Up @@ -18,7 +18,8 @@
"install:builders": "npm i -D ./projects/builders/builders.tar.gz",
"github-actions:unit-tests-core": "ng test core --watch=false --code-coverage",
"github-actions:unit-tests-ui": "ng test ui --watch=false --code-coverage",
"test:code-coverage": "ng test --code-coverage"
"test:code-coverage": "ng test --code-coverage",
"postinstall": "npm run build:builders && npm run install:builders"
},
"private": true,
"dependencies": {
Expand Down Expand Up @@ -51,6 +52,7 @@
"@angular/compiler-cli": "13.0.2",
"@angular/language-service": "13.0.2",
"@compodoc/compodoc": "1.1.16",
"@tsmonkeypatch/ngx-builders": "file:projects/builders/builders.tar.gz",
"@types/jasmine": "3.10.2",
"@types/jasminewd2": "2.0.10",
"@types/node": "16.11.10",
Expand Down
3 changes: 2 additions & 1 deletion src/projects/builders/src/playwright/index.ts
Expand Up @@ -25,6 +25,8 @@ function playwrightBuilder(
let server: BuilderRun | null = null;

// startup
// maybe we need this directly and not later
// in this case we need something like a model
const main$ = from(playwrightService.initialize())
.pipe(
switchMap(() => {
Expand All @@ -41,7 +43,6 @@ function playwrightBuilder(
// watch mode
if (options.watch) {
const fileWatcherService = new FileWatcherService(options.watchDir)
console.dir(options.watchDir)
const progress$ = main$.pipe(
switchMap(() => server?.progress ?? EMPTY),
filter((progress) => progress.state === State.Stopped),
Expand Down
3 changes: 1 addition & 2 deletions src/projects/builders/src/playwright/utils/playwright.ts
Expand Up @@ -39,9 +39,8 @@ export class PlaywrightService {
if (path && path.trim() !== '') {
// for windows systems we get something like this foo\\file.spec.ts which not works
// together with playwright since he do not understand this one (even on windows)
// and replace to foo/file.spec.ts
// and replace with foo/file.spec.ts
playwrightArgs.push(relative(this.rootDir ?? '.', path).replace(/\\/g, '/'))
console.log(playwrightArgs)
}

this.process = spawn(playwrightCommand, playwrightArgs, {
Expand Down

0 comments on commit 3ba38a5

Please sign in to comment.