Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.0 #142

Merged
merged 15 commits into from
Jan 25, 2021
Merged

OAuth 2.0 #142

merged 15 commits into from
Jan 25, 2021

Conversation

maelle
Copy link
Member

@maelle maelle commented Dec 18, 2020

Fix #139

@maelle
Copy link
Member Author

maelle commented Jan 5, 2021

👋 @gaborcsardi (no hurry though 🙂 )

@pr130
Copy link

pr130 commented Jan 24, 2021

thanks @maelle for sending me this PR to have a look at. Here are some minor things i spotted:

  • in the sentence "The whole point of the OAuth 2.0 dance is to get an access token." , I'd add a "such", i.e. "to get such an access token". this makes the reference to the previous definition sentence more clear.
  • typo Intestingly -> Interestingly
  • the code output "MEETUPR_PWD="e46b7faf296e3f0624e6240a6efafe3dfb17b92ae0089c7e51952934b60749f2"" seems a bit out of place where it currently is (context is missing). Also, i feel like the bullet point list before kind of implies that there is an order to them which is a bit shuffled because the secret is needed for the encryption. But i might just be tired and overthinking this ;)
  • Please share any further tip or example you like in the comments below! -> i'd pluralize: "tips or examples".

overall, a very good blog post :) I feel like the target audience would be people who have worked with lets say rtweet before but now have to implement their own httr oauth (which indeed I found tricky in the past!!) - is that correct? the second part about encryption was totally new to me and i'm super excited for the possibilities that has ("integration tests" on github actions?). :)

maybe in the conclusion, there could be some key takeaways, otherwise the end is a bit abrupt (but it's ok!)

@maelle
Copy link
Member Author

maelle commented Jan 25, 2021

Thanks a ton @friep, this was very useful!

Yes regarding integration tests! In the HTTP testing in R book, there's a chapter about making real requests.

Copy link
Contributor

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Looks great! Added some minor comments.

content/post/2021-01-05-oauth2/index.Rmd Outdated Show resolved Hide resolved
content/post/2021-01-05-oauth2/index.Rmd Outdated Show resolved Hide resolved
content/post/2021-01-05-oauth2/index.Rmd Outdated Show resolved Hide resolved
content/post/2021-01-05-oauth2/index.Rmd Outdated Show resolved Hide resolved
content/post/2021-01-05-oauth2/index.Rmd Outdated Show resolved Hide resolved
@maelle maelle merged commit 11e1ba0 into master Jan 25, 2021
@maelle maelle deleted the oauth2 branch January 25, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is OAuth2.0
3 participants