-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth 2.0 #142
Conversation
👋 @gaborcsardi (no hurry though 🙂 ) |
thanks @maelle for sending me this PR to have a look at. Here are some minor things i spotted:
overall, a very good blog post :) I feel like the target audience would be people who have worked with lets say rtweet before but now have to implement their own httr oauth (which indeed I found tricky in the past!!) - is that correct? the second part about encryption was totally new to me and i'm super excited for the possibilities that has ("integration tests" on github actions?). :) maybe in the conclusion, there could be some key takeaways, otherwise the end is a bit abrupt (but it's ok!) |
Thanks a ton @friep, this was very useful! Yes regarding integration tests! In the HTTP testing in R book, there's a chapter about making real requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Looks great! Added some minor comments.
Fix #139