-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the examples be in \dontrun? #60
Labels
bug
an unexpected problem or unintended behavior
Milestone
Comments
Working on this. |
it seems done? |
not really.
…On Tue, Nov 12, 2019 at 2:40 PM Maëlle Salmon ***@***.***> wrote:
it seems done?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#60?email_source=notifications&email_token=AAFBGQGEQSIOA7VGNWGLBDLQTK565A5CNFSM4JGHPUK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2OWEQ#issuecomment-552921874>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFBGQCZ27NPKOQH4BBOEK3QTK565ANCNFSM4JGHPUKQ>
.
|
btw is there an automatic way to assess how many examples are in dontrun? |
IDK, you can parse them and count the lines, but IDK if it's worth it....
code coverage by examples is a measure I guess
…On Tue, Nov 12, 2019 at 2:42 PM Maëlle Salmon ***@***.***> wrote:
btw is there an automatic way to assess how many examples are in dontrun?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
"code coverage by examples is a measure I guess" do you mean it's provided by something? |
covr::package_coverage(type = "examples") |
We'll rather do #' \dontshow{ if (pingr::is_online()) withAutoprint(\{ }
#' ...
#' \dontshow{ \}) } |
gaborcsardi
added a commit
that referenced
this issue
Nov 13, 2019
Use \dontshow{} and check for internet connection. Closes #60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: