Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the examples be in \dontrun? #60

Closed
maelle opened this issue Oct 29, 2019 · 8 comments
Closed

Should the examples be in \dontrun? #60

maelle opened this issue Oct 29, 2019 · 8 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@maelle
Copy link
Member

maelle commented Oct 29, 2019

No description provided.

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Oct 31, 2019
@gaborcsardi
Copy link
Contributor

Working on this.

@gaborcsardi gaborcsardi added this to the pkgsearch 3.0.0 milestone Oct 31, 2019
@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

it seems done?

@gaborcsardi
Copy link
Contributor

gaborcsardi commented Nov 12, 2019 via email

@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

btw is there an automatic way to assess how many examples are in dontrun?

@gaborcsardi
Copy link
Contributor

gaborcsardi commented Nov 12, 2019 via email

@maelle
Copy link
Member Author

maelle commented Nov 12, 2019

"code coverage by examples is a measure I guess" do you mean it's provided by something?

@gaborcsardi
Copy link
Contributor

"code coverage by examples is a measure I guess" do you mean it's provided by something?

covr::package_coverage(type = "examples")

@gaborcsardi
Copy link
Contributor

We'll rather do

#' \dontshow{ if (pingr::is_online()) withAutoprint(\{ }
#' ...
#' \dontshow{ \}) }

gaborcsardi added a commit that referenced this issue Nov 13, 2019
Use \dontshow{} and check for internet connection.

Closes #60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants