Checkbashisms

[maelle]

start work on #46

[maelle]

A symlink won't work :-( "COPY failed: Forbidden path outside the build context: checkbashisms ()"

[maelle]

@gaborcsardi I've now built the Ubuntu image and it seems checkbashisms is there but I haven't used it

(base) maelle@maelle:~/Documents/R-hub/rhub-linux-builders$ docker run -it 979eb558e1b4
root@2cbd8a4ab959:/# checkbashisms
Usage: checkbashisms [-n] [-f] [-x] script ...
   or: checkbashisms --help
   or: checkbashisms --version
This script performs basic checks for the presence of bashisms
in /bin/sh scripts and the lack of bashisms in /bin/bash ones.

[maelle]

I did the same check as above for Fedora (built the image, ran it interactively to see whether checkbashisms was available, but didn't use checkbashisms).

[maelle]

The error I get for Debian is E: Unable to locate package texlive-generic-recommended

Why is it "texlive-generic-recommended" and not "texlive-plain-generic"?

[maelle]

@gaborcsardi the latest build of the Debian R-hub image on Docker was 9 months ago, were you able to build it locally since then? I'm hoping you might get the same error message. :-)

[maelle]

FWIW if I replace "texlive-generic-recommended" with "texlive-plain-generic" I can build the image, and in it I can find checkbashisms, but I suppose it might break LaTeX stuff at the same time.

[gaborcsardi]

FWIW if I replace "texlive-generic-recommended" with "texlive-plain-generic" I can build the image, and in it I can find checkbashisms, but I suppose it might break LaTeX stuff at the same time.

Seems like that's the correct package indeed.

[maelle]

made the change @gaborcsardi

[maelle]

@gaborcsardi is there anything else I should do?

[gaborcsardi]

Thanks!

[maelle]

Can I merge this @gaborcsardi? And once it's merged, what does it take to deploy updated images?

[gaborcsardi]

Thanks!