Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status URLs are http vs https #191

Closed
hrbrmstr opened this issue Jan 19, 2019 · 1 comment
Closed

Status URLs are http vs https #191

hrbrmstr opened this issue Jan 19, 2019 · 1 comment

Comments

@hrbrmstr
Copy link

version 1.0.2

> rhub::check_for_cran(show_status = FALSE)
─  Building package
─  Uploading package
─  Preparing build, see status at
   http://builder.r-hub.io/status/sergeant_0.8.0.tar.gz-2396d86765124beb94d80f6d93938de7
   http://builder.r-hub.io/status/sergeant_0.8.0.tar.gz-d69229b2c1b14fc29e93a80ad0d883bd
   http://builder.r-hub.io/status/sergeant_0.8.0.tar.gz-e902ca0097ee45ae8ea514093ac0488f

builder.r-hub.io does redirect to https on access but that still partially exposes host and request.

I can PR a sub() but this looks like the non-https URLs are coming in the response from the server so that may be a better place to handle it.

@gaborcsardi
Copy link
Collaborator

Fixed by r-hub/rhub-frontend@bac9e02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants