Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/42 read zip renishaw #57

Merged
merged 10 commits into from
Aug 10, 2021
Merged

Conversation

sangttruong
Copy link

@sangttruong sangttruong commented Aug 6, 2021

Resolve #42

Copy link
Member

@GegznaV GegznaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more unit tests

@@ -233,12 +233,11 @@ read_zip_Renishaw <- function(file = stop("filename is required"),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sangttruong, please, apply/use template #55 for unit testing read_zip_Renishaw()

@GegznaV GegznaV marked this pull request as draft August 9, 2021 12:20
@sangttruong sangttruong marked this pull request as ready for review August 10, 2021 00:01
Copy link
Collaborator

@bryanhanson bryanhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like comments and requested changes were addressed. Ready to merge.

@sangttruong sangttruong merged commit 10975e5 into develop Aug 10, 2021
@sangttruong sangttruong deleted the features/42-read-zip-Renishaw branch August 10, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review, add and improve unit tests
3 participants