Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizers #92

Closed
gaborcsardi opened this issue Aug 20, 2016 · 2 comments
Closed

Finalizers #92

gaborcsardi opened this issue Aug 20, 2016 · 2 comments

Comments

@gaborcsardi
Copy link
Member

gaborcsardi commented Aug 20, 2016 •
edited

I know I can use reg.finalizer, in initialize or on the object, but what do you think about making finalizers more explicit, i.e. having a special finalize method?

It should not be too hard with reg.finalizer. We just check if there is a finalize method at object creation, and if there is, we call reg.finalizer on it.
@wch
Copy link
Member

wch commented Aug 21, 2016

Sounds like a good idea to me!

@gaborcsardi
Copy link
Member Author

OK, I'll put together a PR.

@gaborcsardi gaborcsardi changed the title destructor Finalizers Aug 22, 2016
@wch wch closed this as completed in fa7dd31 Aug 22, 2016
wch added a commit that referenced this issue Aug 22, 2016
@wch
Merge pull request #93 from gaborcsardi/destructor
9ca3108 
Finalizers, closes #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wch @gaborcsardi