Allow for a custom clone() method #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename clone() to .clone(). - Create a default clone() that calls .clone() - Add test for overriding clone() See r-lib#179 (comment) for details
If a class defines a post_clone() method, it will automatically be called on the newly created object. This is convenient because post_clone() allows to modify private fields of the new object at its creation. See r-lib#179 (comment)
clone() can now be overridden and it may have additional arguments. deep_clone() usually calls clone() for some fields, so it makes sense that we pass along additional arguments as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I took the comment from #179 (comment) by @wch and implemented it, adapting contributions from @mb706. I added tests and documentation.
Each commit is self-contained and backwards compatibility should be preserved.
Thanks for your work on R6, it feels easier than RC classes (at least to me!).